Check existence of the order in the orderbook, and add polledOrderInOrderbook #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
alfetopito
reviewed
Sep 12, 2023
|
The unit tests are broken :/ |
|
Unit tests are still failing. |
|
@alfetopito worked for me. 
|
|
Test are ✅ GREEN! |
|
@alfetopito merging, let me know if you have any other comments |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a 2 things:
A new check, after we get the order that "should" be created, we double-check if it was already created or not by quering the orderbook.
After we verify the existence of the order, the polling will return by default
TRY_NEXT_BLOCK, but at the same time it will give the concrete order to give a different result. This will allow orders like Twap to say: "Ok, so if current part is already created, next part should be starting by this exact time, therefore it will return aTRY_AT_EPOCHoverridingTRY_NEXT_BLOCKdefault).This will allow orders to be polled much more efficiently, for example, DCA that trades once a month, you will not need to check every block between two months.
Also, another efficiency, is that watch towers will not need to post the orders if someone else already posted it, reducing drastically the errors of
DuplicatedOrder.Not included
Next PRs I plan to add: